Motor, setSpeed and constructor

[Ricoco]

Hi !

I want to set the speed (max) of my motor once and for all my program.

The following code is not working :

import lejos.nxt.*;

public class MonRobot implements ButtonListener {

NXTRegulatedMotor motorB = Motor.B;
NXTRegulatedMotor motorC = Motor.C;

public void MonRobot() {
motorB.setSpeed(900);
motorC.setSpeed(900);
}

public void avance() {
/*Motor.B.setSpeed(900);
Motor.C.setSpeed(900);*/
Motor.B.forward();
Motor.C.forward();
}

public void recule() {
Motor.B.backward();
Motor.C.backward();
}

public void tourne() {
Motor.B.forward();
}

public void buttonPressed(Button b) {
}

public void buttonReleased(Button b) {
System.exit(0);
}

public static void main(String[] args) throws Exception {

MonRobot robot = new MonRobot();

Button.ESCAPE.addButtonListener(robot);

TouchSensor capteur = new TouchSensor(SensorPort.S1);

robot.avance();

while(true) {
if (capteur.isPressed()) {
robot.recule();
Thread.sleep(1000);
robot.tourne();
Thread.sleep(500);
robot.avance();
System.out.println("Sortie de boucle");
}
}

}

}

Sorry for the french in the code...

The red part doesn't give the behavior expected.

If i suppress comments, the green code is giving me the behavior i want.

Why ? Thx in advance.

[Rickz2020]

Have you tried:

Code: Select all

public void MonRobot() {
motor.B.setSpeed(900);
motor.C.setSpeed(900);
}


?

You declare MotorB and MotorC but never use it, so setting the speed will have no effect. I think it's just a typo you've made

[gloomyandy]

Hi,
Your code does not have a constructor it has a void method called MonRobot. Constructors should not have a type associated with them. Change the code to:

Code: Select all

public class MonRobot implements ButtonListener {

NXTRegulatedMotor motorB = Motor.B;
NXTRegulatedMotor motorC = Motor.C;

public MonRobot() {
motorB.setSpeed(900);
motorC.setSpeed(900);
}

Note the lack of void. The above works fine for me.... As the previous poster pointed out you would probably be better off using motorA and motorB in your code rather than Motor.A and Motor.B

Andy

[Ricoco]

Thx you very much !

As you've seen, i've to improve my Java programming level (i haven't code since years).

[gloomyandy]

Hi,
No problem, to be honest I'm a little surprised that this is actually allowed (though it does generate a warning in Eclipse)...

Andy